Fix issue#7 : persistent wallet connection for ArConnect Wallet#8
Open
mr-harshtyagi wants to merge 1 commit intoDanMacDonald:finishedfrom
Open
Fix issue#7 : persistent wallet connection for ArConnect Wallet#8mr-harshtyagi wants to merge 1 commit intoDanMacDonald:finishedfrom
mr-harshtyagi wants to merge 1 commit intoDanMacDonald:finishedfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Issue Description :
After first wallet connection with ArConnect Wallet, the state are refreshed on reload and wallet connection does not persist. Due to this, connect wallet also doesn't work
Please review the changes and merge.
This demo is most used by developers to learn permaweb and Arweave and i believe that it should be as good as possible to avoid any issues in initial learning phase. The blog https://arwiki.arweave.dev/#/en/creating-a-dapp can also be updated to account for same. I will be happy to collaborate and work on these issues :)