[DRAFT] Add support for Storing audit logs in a single table#235
Draft
ldaspt wants to merge 1 commit intoDamienHarper:masterfrom
Draft
[DRAFT] Add support for Storing audit logs in a single table#235ldaspt wants to merge 1 commit intoDamienHarper:masterfrom
ldaspt wants to merge 1 commit intoDamienHarper:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 97.15% 95.59% -1.56%
==========================================
Files 42 43 +1
Lines 1721 1838 +117
==========================================
+ Hits 1672 1757 +85
- Misses 49 81 +32 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow storing all audit logs in a single table instead of creating a separate table for each audited entity.
I am aware of the performance issues that this can cause on an application with a large volume DATA-DOG/DataDogAuditBundle#32
This PR is a work in progress to validate the design and approach.
I test the feature on the demo https://github.com/DamienHarper/auditor-bundle-demo by adding in
config/services.yamlWork Remaining:
Clean audit tablesandUpdate audit tablescommands to support this feature.