feat: add OMOS PR1 scoring v2 and resolver foundation#4
Open
Daltonganger wants to merge 1 commit intofeat/dynamic-provider-fallback-pr3from
Open
feat: add OMOS PR1 scoring v2 and resolver foundation#4Daltonganger wants to merge 1 commit intofeat/dynamic-provider-fallback-pr3from
Daltonganger wants to merge 1 commit intofeat/dynamic-provider-fallback-pr3from
Conversation
Introduce modular V2 scoring components, shadow-mode plumbing, and deterministic precedence resolution with provenance while keeping V1 as the applied default. Adds schema flag support and regression tests for determinism and fallback compilation.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (9 files)
SummaryThis PR introduces a new scoring engine (v2) with shadow mode support for A/B testing model selection algorithms. The implementation is clean and well-tested:
The code follows project conventions (Biome formatting, TypeScript strict mode, proper exports). |
|
@copilot review this with a free model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cli/scoring-v2(features, weights, engine, explainable score breakdown)scoringEngineVersionflag support (v1 | v2-shadow | v2) with shadow plumbing that compares V1/V2 while still applying V1 in shadow modeNotes
feat/dynamic-provider-fallback-pr3/omosUX are intentionally out of scope for this PRValidation
bun test src/cli/scoring-v2/engine.test.ts src/cli/precedence-resolver.test.ts src/cli/dynamic-model-selection.test.ts src/cli/providers.test.ts src/config/loader.test.tsbun run check:ci(passes with existing Biome schema-version info message)