make LOG_FILE_PATH an optional production config value#184
Open
odrling wants to merge 1 commit intoDakaraProject:developfrom
Open
make LOG_FILE_PATH an optional production config value#184odrling wants to merge 1 commit intoDakaraProject:developfrom
odrling wants to merge 1 commit intoDakaraProject:developfrom
Conversation
In our deployment in kubernetes[1] we usually use the standard output of the service which is captured by k8s, so the logs can be read from any tool in the k8s ecosystem. Setting LOG_FILE_PATH to /dev/stdout doesn’t work as RotatingFileHandler needs a seekable file to work correctly (needs to tell the current file position to rotate the logs). So this allows to use the standard output for logs when LOG_FILE_PATH is not set. [1]: https://github.com/Japan7/nanak8s
Contributor
Author
|
Just noticed this PR has conflicts with #183, so perhaps it should be done there instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our deployment in kubernetes1 we usually use the standard output of the service which is captured by k8s, so the logs can be read from any tool in the k8s ecosystem.
Setting LOG_FILE_PATH to /dev/stdout doesn’t work as RotatingFileHandler needs a seekable file to work correctly (needs to tell the current file position to rotate the logs).
So this allows to use the standard output for logs when LOG_FILE_PATH is not set.