Skip to content

Comments

Improve management of instrumental tracks#140

Merged
Neraste merged 2 commits intodevelopfrom
refactor/instrumental-tracks
Mar 1, 2025
Merged

Improve management of instrumental tracks#140
Neraste merged 2 commits intodevelopfrom
refactor/instrumental-tracks

Conversation

@Neraste
Copy link
Member

@Neraste Neraste commented Mar 1, 2025

  • For mpv: SongMedia.track_id_audio stores the instrumental track ID and USE_PATH_AUDIO if an instrumental file should be used;
  • For VLC: Do some renaming.

@Neraste Neraste self-assigned this Mar 1, 2025
@Neraste Neraste added the refactor Make things more beautiful inside, but same outside label Mar 1, 2025
@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (15a2d3d) to head (28e43b8).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #140   +/-   ##
========================================
  Coverage    98.03%   98.04%           
========================================
  Files           16       16           
  Lines         1377     1381    +4     
========================================
+ Hits          1350     1354    +4     
  Misses          27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste Neraste merged commit eba8f2c into develop Mar 1, 2025
16 checks passed
@Neraste Neraste deleted the refactor/instrumental-tracks branch March 1, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Make things more beautiful inside, but same outside

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant