Skip to content

Comments

New management of directories#110

Merged
Neraste merged 4 commits intodevelopfrom
refactor/directories
Nov 19, 2022
Merged

New management of directories#110
Neraste merged 4 commits intodevelopfrom
refactor/directories

Conversation

@Neraste
Copy link
Member

@Neraste Neraste commented Nov 19, 2022

This PR allows to use a new library in Dakara base for managing user directory across different operating systems.

Part of the work was done in c4b3bed. Parts of #107 were ported to this PR.

@Neraste Neraste added the refactor Make things more beautiful inside, but same outside label Nov 19, 2022
@Neraste Neraste self-assigned this Nov 19, 2022
@Neraste Neraste added this to the 1.8.0 milestone Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #110 (4e75223) into develop (3a64f61) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #110   +/-   ##
========================================
  Coverage    98.36%   98.36%           
========================================
  Files           16       16           
  Lines         1346     1346           
========================================
  Hits          1324     1324           
  Misses          22       22           
Impacted Files Coverage Δ
src/dakara_player/font.py 98.19% <100.00%> (+0.08%) ⬆️
src/dakara_player/media_player/base.py 100.00% <100.00%> (ø)
src/dakara_player/media_player/vlc.py 97.82% <100.00%> (+<0.01%) ⬆️
src/dakara_player/user_resources.py 93.10% <100.00%> (-1.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Neraste Neraste merged commit 77da9a6 into develop Nov 19, 2022
@Neraste Neraste deleted the refactor/directories branch November 19, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Make things more beautiful inside, but same outside

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant