Open
Conversation
…action, similarly extracted print_incorrect_message into incorrect_input_action which also asks the player if they want to start over
… which ask for all answers to reach end
| def ask_question([], _), do: perfect_score_message | ||
| def ask_question([current_question | next_questions], score) do | ||
| validate_input(request_answer(current_question[:question]), current_question[:answer], score, next_questions) | ||
| request_answer(current_question[:question]) |
There was a problem hiding this comment.
I would expand this pipe 😄
current_question[:question]
|> request_answer
|> validate_answer...
|> continue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to work on:
Extracting functions for clarity.
Naming functions for clarity.
Making functions private where their behaviour can be tested through other functions.
Any feedback on this would be super!