Bug: uploading metadata from a dataframe fails if pandas>=3 #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where uploading metadata from a pandas DataFrame fails with pandas version 3.x due to changes in how DataFrame dtypes are represented. The main fix updates the dtype checking logic to use pandas API methods instead of direct string comparison.
Changes:
- Updated dtype checking to use
pandas.api.types.is_string_dtype()instead of comparing dtype to "object" string - Reorganized imports to alphabetical order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kbolashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the broken test cases in https://github.com/DagsHub/client/blob/7c4169f229f460d2e8e1226f1e00581038d51708/tests/data_engine/test_datasource.py
Pandas 3 changed the types of values that get returned from
df.dtypes, and the current check that we had is failing.Instead switch to calling
pandas.api.types.is_string_dtypeThe actual functionality change is only at the bottom, everything else is import reorganization