Add support for W3C Trace Context in graphql requests #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also catch and wrap TransportServerError to add the trace ID in the logged error.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for W3C Trace Context in GraphQL requests by implementing traceparent header generation and improving error handling to include trace IDs in logged errors.
Changes:
- Implemented W3C Trace Context traceparent header generation with non-zero validation
- Updated GraphQL client to include traceparent headers in requests
- Enhanced error handling to catch TransportServerError and use traceparent as fallback support ID
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dagshub/common/tracing.py | New module implementing W3C Trace Context traceparent generation with proper validation |
| dagshub/data_engine/client/data_client.py | Updated GraphQL execution to add traceparent headers and improved error handling with fallback to trace ID |
| dagshub/common/config.py | Added configuration flag to allow disabling traceparent functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kbolashev
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also catch and wrap TransportServerError to add the trace ID in the logged error.