-
Notifications
You must be signed in to change notification settings - Fork 28
Infra: allow for multiple install_hooks() running at the same time #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kbolashev
wants to merge
14
commits into
main
Choose a base branch
from
infra/multi-hooks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ab21939
Move DagsHubFilesystem to use RepoAPI to download files
kbolashev 7079a61
Add Ruff
kbolashev d283174
Extract parse_path to DagshubPath
kbolashev b34e082
Install hooks via a router works now
kbolashev 229f1b0
Enhance install/uninstall hooks, write tests that handle most of the …
kbolashev 351181b
Change error help for FilesystemAlreadyMountedError
kbolashev 973a4e6
tenacity fix
kbolashev fb8dc04
Add a message explaining what the hooks are doing to the user
kbolashev 033211b
Explain the ignored rules
kbolashev 56e089b
Fully qualify the uninstall_hooks function in the error
kbolashev ae90a43
Ignore 6xx+ status codes in is_server_error_exception
kbolashev df087b2
Retry: reuse between functions, add jitter, make the max wait 5 minutes
kbolashev 3d63f50
Carry over original path in DagshubPath as-is without turning it into…
kbolashev 2ef659c
Merge branch 'master' into infra/multi-hooks
kbolashev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.