Skip to content

decoding: treat mis-transcribed z or o (2 or 0) generously. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

decoding: treat mis-transcribed z or o (2 or 0) generously. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/decode_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,14 @@ mod tests {
buffer.clear();
decode(test.encoded, &mut buffer, test.bits).unwrap();
assert_eq!(&buffer[..], test.unencoded);
buffer = Vec::new();
decode(test.encoded.replace("z", "2").as_str(), &mut buffer, test.bits).unwrap();
assert_eq!(&buffer[..], test.unencoded,
"failed to decode when 2 replaces z: {} (got: {:?})", test.encoded, buffer);
buffer = Vec::new();
decode(test.encoded.replace("o", "0").as_str(), &mut buffer, test.bits).unwrap();
assert_eq!(&buffer[..], test.unencoded,
"failed to decode when 0 replaces o: {} (got: {:?})", test.encoded, buffer);
}
}

Expand Down
8 changes: 5 additions & 3 deletions src/tables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
// Maps from character code to their value in the z-base-32 scheme
// Table starts from character code 49 ('1')
pub const CHARACTER_MIN_VALUE: u8 = 49;
// Table starts from character code 48 ('0')
pub const CHARACTER_MIN_VALUE: u8 = 48;
pub const CHARACTER_TO_QUINTET: &'static [u8] = &[
16, // '0' (misread of 'O')
18, // '1'
255, 25, // '3'
23, // '2' (misread of 'Z')
25, // '3'
26, // '4'
27, // '5'
30, // '6'
Expand Down