Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for creating custom locations with locally stored photos, enabling offline creation and later synchronization when the device comes back online.
Changes:
- Add offline photo capture/gallery picking in the “Add custom location” flow and persist photos locally.
- Implement sync logic for pending custom locations + photo uploads, triggered both on submit and when network comes online.
- Switch API base URL to be environment-driven and wire CI/build workflows to provide
API_URL.
Reviewed changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/stores/map-store.js |
Updates ortho layer capabilities endpoint and layer name. |
src/stores/local-custom-location-store.js |
Adds local photo persistence, photo upload, sync orchestration, and rollback for failed creates. |
src/router/routes.js |
Allows custom location details route to resolve by numeric id or offline externalId. |
src/pages/CustomLocationSearchPage.vue |
Navigates to details using externalId for offline items; shows offline indicator. |
src/pages/CustomLocationDetailsPage.vue |
Displays local + remote photos, thumbnails, and full-screen viewing. |
src/i18n/sl-SI/index.js |
Adds new UI strings for photos/offline flow (with one typo). |
src/i18n/en-US/index.js |
Adds new UI strings for photos/offline flow. |
src/helpers/photo-storage.js |
New helper for saving/reading/deleting photos on Cordova FS or browser OPFS. |
src/helpers/network.js |
New helper to track online/offline state and fire “back online” callbacks. |
src/db/db.js |
Adds DB migration to move files records from data to filePath-based storage. |
src/components/custom-locations/AddLocation.vue |
Adds camera/gallery UI, previews, submit loading state, and offline-aware create+sync. |
src/boot/axios.js |
Uses process.env.API_URL (with localhost fallback) for API base URL. |
src/App.vue |
Initializes network tracking and triggers custom-location sync when coming online. |
src-cordova/package.json |
Adds Cordova camera/file plugins. |
src-cordova/package-lock.json |
Updates lockfile, but only includes cordova-plugin-file. |
quasar.config.js |
Exposes API_URL via Quasar env config. |
package.json |
Adds build-mobile-prod script and introduces cross-env. |
package-lock.json |
Adds cross-env and its dependencies. |
.gitignore |
Ignores local env override files. |
.github/workflows/test.yml |
Provides API_URL during PR build. |
.github/workflows/build.yml |
Provides API_URL during main build/deploy. |
Files not reviewed (1)
- src-cordova/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to support adding custom locations with photos. This PR also sets ground for adding custom locaitons in "offline" mode to sync them later.