Skip to content

Feature/ykermaid pdvd tde reco#214

Open
YoannKermaidic wants to merge 4 commits intodevelopfrom
feature/ykermaid_pdvd_tde_reco
Open

Feature/ykermaid pdvd tde reco#214
YoannKermaidic wants to merge 4 commits intodevelopfrom
feature/ykermaid_pdvd_tde_reco

Conversation

@YoannKermaidic
Copy link
Member

Particularly useful for PDVD laser data taken in Nov. 2025 with the custom TDE DAQ
Goes along with DUNE/duneprototypes#98

@YoannKermaidic
Copy link
Member Author

trigger build

@YoannKermaidic
Copy link
Member Author

@tomjunk
This is needed for the PDVD CI, TDE DAQ data decoding and simulation.

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase build DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard

@YoannKermaidic
Copy link
Member Author

trigger build

@YoannKermaidic
Copy link
Member Author

Hi @tomjunk
Seems like the trigger build is failing for unknown reason. Is it still possible to validate this PR?
This is important to get the PDVD detsim working.

Copy link
Member

@lpaulucc lpaulucc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@tomjunk tomjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, too.

@YoannKermaidic
Copy link
Member Author

@wyjang-uta
I'd like to raise your attention on this PR that is needed to debug the PDVD simulation workflow and the also the PDVD CI test. So if it can be merged for the next release, that would be fantastic.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants