Skip to content

PDVD OpDetDigitizer fix#128

Open
lpaulucc wants to merge 3 commits intodevelopfrom
lp_pdvddigitizerfix
Open

PDVD OpDetDigitizer fix#128
lpaulucc wants to merge 3 commits intodevelopfrom
lp_pdvddigitizerfix

Conversation

@lpaulucc
Copy link
Member

@lpaulucc lpaulucc commented Jan 27, 2026

This fixes a bug in the processing of input tags for the PDVD digitizer in what concerns argon and xenon properties.
It also reintroduces the ScintPreScale compensator as this will be needed for cosmic simulation given ROOT I/O restrictions and memory consumption.

@lpaulucc lpaulucc requested review from jroto and vpec0 January 27, 2026 09:43
@vpec0
Copy link
Member

vpec0 commented Jan 27, 2026

This PR looks like a merge of two or more PRs. 1) There's the new calibrator for PD VD, 2) added accounting for light prescaling in the light simulations, 3) fix to the processing of the input tags.

@lpaulucc
Copy link
Member Author

Oh, sorry, the calibrator was not supposed to be here. Let me remove this (it is a different PR, current draft)

@vpec0
Copy link
Member

vpec0 commented Jan 27, 2026

OK, so now this is just: 2) added accounting for light prescaling in the light simulations, 3) fix to the processing of the input tags.

@lpaulucc
Copy link
Member Author

Correct. I have updated the PR description.

Copy link
Member

@vpec0 vpec0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lpaulucc
Copy link
Member Author

lpaulucc commented Feb 4, 2026

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants