Conversation
|
This PR looks like a merge of two or more PRs. 1) There's the new calibrator for PD VD, 2) added accounting for light prescaling in the light simulations, 3) fix to the processing of the input tags. |
|
Oh, sorry, the calibrator was not supposed to be here. Let me remove this (it is a different PR, current draft) |
|
OK, so now this is just: 2) added accounting for light prescaling in the light simulations, 3) fix to the processing of the input tags. |
|
Correct. I have updated the PR description. |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
This fixes a bug in the processing of input tags for the PDVD digitizer in what concerns argon and xenon properties.
It also reintroduces the ScintPreScale compensator as this will be needed for cosmic simulation given ROOT I/O restrictions and memory consumption.