Skip to content

Feature: Channel by channel gain configuration for opdet deconvolution#126

Draft
vpec0 wants to merge 3 commits intodevelopfrom
feature/vpec_chbych_gain_in_deconv
Draft

Feature: Channel by channel gain configuration for opdet deconvolution#126
vpec0 wants to merge 3 commits intodevelopfrom
feature/vpec_chbych_gain_in_deconv

Conversation

@vpec0
Copy link
Member

@vpec0 vpec0 commented Dec 19, 2025

Introducing feature to allow configuration of gains for each channel in the deconvolution algorithm. The gains are used to normalise the output waveform - the SPE templates' amplitudes are normalised to the specified gain (number of ADCs per SPE).

The gains are expected to come within an ascii file: each row specifies the channel number and the gain, separated by whitespace.

The new configurable for the deconvolution module is ChannelGainFile. If it is an empty string, no rescaling is done and the SPE amplitude is equal to the amplitude of the corresponding SPE template.

So far, no checks are done if all channels have the gain set and it is implicitly assumed that they are. The case where only subset of channels have their gains set would lead to a segfault.

@vpec0 vpec0 requested a review from lpaulucc December 19, 2025 10:50
Copy link
Member

@lpaulucc lpaulucc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. But should it not have a default value (empty?) for ChannelGainFile when the parameter is read or in the Deconvolution.fcl?

@vpec0
Copy link
Member Author

vpec0 commented Jan 12, 2026

@lpaulucc Yes, I was thinking about that. I am inclined to keep the configurable without default, but specify an empty string in the default config fhicl. I'll do this when I get back to it. I still need to implement some undefined-situation handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants