2 bugs in make.report #21
Conversation
There are two major bugs in `make.report` : First, specifying a path and file name in the argument `reportfile`, does not work. I propose following changes, which allow specifying a path only, a path with file name, a file name only, or an empty string for the argument `reportfile` (as is was stated in the help document). Note that `dirname(reportfile) == "."` is necessary as the `dirname` of a file name only, results in a period, which is identified as a valid path. Second, when the file name contains a space in one of the directory names, the `system` function does not provide the correct path name to the console. This problem was caused on my Mac, but I think "\ " for escaping space with a backslash is universal across OS.
| if(file.access(dirname(reportfile), mode=1) != 0) reportfile <- file.path(getwd(), reportfile) | ||
|
|
||
| # if file name specified | ||
| if("tex" %in% unlist(strsplit(basename(reportfile),"[.]"))){ |
There was a problem hiding this comment.
The test here could be: grepl(".+[.](tex)$", reportfile)
| if(basename(reportfile) == "") reportfile <- 'report.tex' | ||
| if(file.access(dirname(reportfile), mode=1) != 0) reportfile <- file.path(getwd(), reportfile) | ||
|
|
||
| # if file name specified |
There was a problem hiding this comment.
There are too many comments and not all of them say what the code does. E.g. here the code checks if "tex" is between dots in the reportfile string, not if a file is specified. Small difference, but maybe crucial.
|
|
||
| # -- Compile tex file -- # | ||
| #latexcompile <- system(paste('pdflatex -output-directory=../res/', reportfile), intern=TRUE) | ||
| latexcompile <- system(paste(paste0('pdflatex -output-directory=',file.path(dirname(reportfile))), file.path(reportfile)), intern=TRUE) |
There was a problem hiding this comment.
Couldn't we just put the file path and the file name in quotes and remove the double paste?
latexcompile <- system(paste0('pdflatex -output-directory="', file.path(dirname(reportfile)), '" "', file.path(reportfile), '"'))
| #' @param keep.figurefiles If TRUE generated figure files will not be cleaned up. | ||
| #' @param keep.txtfiles If TRUE generated txt files will not be cleaned up. | ||
| #' @param keep.texfiles If TRUE generated tex file will not be cleaned up. | ||
| #' @return Nothing. |
There was a problem hiding this comment.
This function returns TRUE or invisible(NULL) depending on !keep.figurefiles, not nothing! But maybe it should return something like the pdf filename with full path, so one could open it using system(paste(getOption("pdfviewer"), outpdf), wait = FALSE). We can also have an argument to show the pdf file after creation.
2 participants
There are two major bugs in
make.report:First, specifying a path and file name in the argument
reportfile, does not work. I propose following changes, which allow specifying a path only, a path with file name, a file name only, or an empty string for the argumentreportfile(as is was stated in the help document). Note thatdirname(reportfile) == "."is necessary as thedirnameof a file name only, results in a period, which is identified as a valid path.Second, when the file name contains a space in one of the directory names, the
systemfunction does not provide the correct path name to the console. This problem was caused on my Mac, but I think "\ " for escaping space with a backslash is universal across OS.