refactor(frontend) experiental PR to create an api client creation factory#566
Draft
refactor(frontend) experiental PR to create an api client creation factory#566
Conversation
Comment on lines
84
to
94
| export const interopClient = createTypedApiClient<InteropPaths>({ | ||
| baseUrl: serverEnvironment.INTEROP_SIN_REG_API_BASE_URL, | ||
| authHeader: serverEnvironment.INTEROP_SIN_REG_API_AUTH_HEADER.value(), | ||
| proxyUrl: serverEnvironment.INTEROP_PROXY_URL, | ||
| }); | ||
|
|
||
| export const powerPlatformClient = createTypedApiClient<PowerPlatformPaths>({ | ||
| baseUrl: serverEnvironment.INTEROP_SIN_SEARCH_API_BASE_URL, | ||
| authHeader: serverEnvironment.INTEROP_SIN_SEARCH_API_AUTH_HEADER.value(), | ||
| proxyUrl: serverEnvironment.INTEROP_PROXY_URL, | ||
| }); |
Contributor
There was a problem hiding this comment.
These clients should not be created within the factory, as it introduces side effects. Instead, consider defining them in a separate module, such as api-clients, and using a function to retrieve them. If a singleton is preferred, lazy loading the client could be an option.
Member
Author
There was a problem hiding this comment.
updated. Marking as draft until funding is figured out I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MARKING AS DRAFT UNTIL FUNDING IS FIGURED OUT
Summary
This is an experimental PR to consolidate common functions and exporting HTTP clients in an
api-client-factorymodule. Currently the application needs at least 2 HTTP clients. One for creating a case, and another for searching hitlist results/associating a SIN. This PR lays the ground work for that.Types of changes
What types of changes does this PR introduce?
(check all that apply by placing an
xin the relevant boxes)Checklist
Before submitting this PR, ensure that you have completed the following. You can fill these out now, or after creating the PR.
(check all that apply by placing an
xin the relevant boxes)Linting and formatting
Unit and e2e tests
npm run test npm run test:e2eAdditional Notes
If this PR introduces significant changes, explain your reasoning and provide any necessary context here. Feel free to include diagrams, screenshots, or alternative approaches you considered.
Screenshots (if applicable)
Provide screenshots or screen-recordings to help reviewers understand the visual impact of your changes, if relevant.