Skip to content

Conversation

@ybnd
Copy link
Member

@ybnd ybnd commented Jun 26, 2025

Currently, metadata PATCH requests with "op": "replace" and an unknown metadata field in the path are treated as if they have "path": "/metadata". This can lead to unexpected loss of metadata as detailed in DSpace/DSpace#10817

This PR documents the changes made in DSpace/DSpace#10961 to resolve this problem: any unknown field in the path will immediately lead to an HTTP 422 response.

The change affects all PATCH operations, to avoid similar problems.

@ybnd ybnd added bug affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases affects: main Issue impacts "main" (latest release). labels Jun 26, 2025
@tdonohue tdonohue self-requested a review June 26, 2025 15:09
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release and removed affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases affects: main Issue impacts "main" (latest release). labels Jun 26, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 26, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @ybnd ! This documentation looks good to me, and I've just tested & merged DSpace/DSpace#10961

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jun 27, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jun 27, 2025
@tdonohue tdonohue merged commit 7993790 into DSpace:main Jun 27, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jun 27, 2025
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants