Conversation
sarthyparty
left a comment
sarthyparty
left a comment
There was a problem hiding this comment.
hopefully my review helps
| @@ -0,0 +1,30 @@ | |||
| name: Lint | |||
There was a problem hiding this comment.
nit: add linter for yaml code, especially since there are many formatting inconsistencies
| @@ -0,0 +1,139 @@ | |||
| name: Main CI Pipeline | |||
|
|
|||
| # on: | |||
There was a problem hiding this comment.
so it doesnt run. i have zero confidence in my abillity to fix things and this is my first time messing with GH workflows/actions and I dont wanna kill prod
|
|
||
| on: | ||
| pull_request: | ||
| # on: |
There was a problem hiding this comment.
this is the old implementation of the build and test procedure. I wanted to keep it around for reference but not have it run
| echo "Running Flyway migrations on server..." | ||
| echo "Current Directory: $(pwd)" | ||
|
|
||
| if [ -z "$DB_HOST" ] || [ -z "$DB_USER" ] || [ -z "$DB_NAME" ] | [ -z "$DB_PASSWORD" ]; then |
There was a problem hiding this comment.
why a single | in the last or statement? is that a bug?
There was a problem hiding this comment.
yes bug. I havent tested this because it gets run on prod and i dont really know whats going on with flyway/db migrations
|
@adrian-brady Nit: common steps—checkout, Go setup, lint/test, SQLC vet/diff, and build—are repeated across several workflows; let’s consolidate them into fewer workflows or a shared composite action. |
could you help me with that? |
2 participants
No description provided.