Open
Conversation
11ea3b6 to
0289c44
Compare
sarthyparty
requested changes
May 11, 2025
| - name: "db" | ||
| path: "./pkg/db/generated" | ||
| queries: "./pkg/db/queries" | ||
| path: "./internal/infrastructure/database/sqlc/generated" |
Contributor
There was a problem hiding this comment.
did you mean internal/infra?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebase Reorganization
Aims to reorganize significant portions of the codebase to establish a clearer distinction between internal implementation components and public-facing, reusable components.
The primary structural change involves the addition of the
internaldirectory for all non-public code, while thepkgdirectory is reserved for components designed for external use or reuse.Changes
internalDirectoryThe internal directory now serves as the primary location for all code that is not to be imported or used directly by external projects or consumers - realistically none of this codebase is designed with external use in mind but still
internal/application/(formerly services):internal/domaininternal/infra/(Infrastructure)internal/infra/aws/: Implementations for AWS clients, services, and data models.internal/infra/database/: Houses all database-related components. This is practically just a directory move from the previous implementation.internal/infra/http/: Includes HTTP request handlers, API routes, middleware, and other components related to the HTTP interface.pkgDirectoryThe pkg directory is now, in theory, more purposely used, holding public-facing, reusable libraries and components.