Draft
Conversation
sarthyparty
requested changes
Apr 28, 2025
| return false | ||
| return result, false | ||
| default: | ||
| select { |
Contributor
There was a problem hiding this comment.
enqueue: adds job to channel. queue map: keys are same as cache (queries). value is slice of result channels.
| return suggestions, nil | ||
| } | ||
|
|
||
| func (c *kendraClientImpl) MakeQuery(ctx context.Context, query string, filters map[string][]string, pageNum int) (KendraResults, error) { |
| c.mu.Lock() | ||
| defer c.mu.Unlock() | ||
|
|
||
| expiration := time.Now().Add(duration).Unix() |
| c.log.DebugContext(ctx, "Kendra query executed successfully", "result_count", queueResult.Value.Count) | ||
|
|
||
| results := queryResult.Results | ||
| results := queueResult.Value |
| res = result | ||
| } | ||
|
|
||
| pageNum := 0 |
Contributor
There was a problem hiding this comment.
Let's not include page numbers in the cache and query for all 100 results and then just return 10 results for page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a cache. It is not finished yet - it currently breaks filters