Conversation
script/db/schema.sql
Outdated
There was a problem hiding this comment.
is this being used by another file? if not, we can delete this
There was a problem hiding this comment.
It is not but I think it should be kept somewhere for future reference, if database needs to be repopulated or backend needs a reference to the schema.
There was a problem hiding this comment.
let's delete it - we can repopulate the schema with a simple command so we shouldn't keep it in there.
|
change your code to use the correct env variables that are outlined in our shared .env file in the drive |
|
Hey Ben, commit names should be in present tense, like "add db population script". The PR name can be the same name as the commit |
bengoh815
changed the title
bengoh815
changed the title
|
why is there a db pipeline folder and a scripts folder within that, and also a scripts folder outside of this db_pipeline? I'm assuming db_pipeline folder is redundant as you don't mention it in the README.md. also, did you end up changing this to work with the shared .env? i would also rename the scripts folder to something more relevant like db_population |
- Uploaded the base script structure - Added requirements.txt for package dependencies - Created README.md with documentation - Updated script to parse through all files - Improved documentation with clearer explanations
Updated for better indication of database usage Updated logger in main for better indication on not found data Updated dynamic models to match latest schema Updated db_manager, add or update function to accommodate new schema changes. Updated s3_manager, removed uncessary print statement and updated regions according to new schema changes.
5 participants
Uh oh!
There was an error while loading. Please reload this page.