Conversation
|
Looks great so far, but I get you are still working on it before we should all review it properly, right? |
Yes, I still have some things I want to do. Should I split the PR into at least two? Maybe one that only has the Redis changes? |
Good idea, let's start to have that merged in independently |
92abe92 to
89a57df
Compare
89a57df to
17d99cc
Compare
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
…dev outside a container Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
f0a6058 to
610abe3
Compare
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
610abe3 to
3fa5c9b
Compare
|
|
||
| - name: Test | ||
| # Wait for RabbitMQ to start. | ||
| run: sleep 10 && make test |
There was a problem hiding this comment.
I don't like this; it would be nice for the tests to wait for RabbitMQ to actually be ready. Also, for some reason the tests didn't do anything for 10 minutes on 3 runs, so maybe this should be disabled?
Suggestions welcome.
|
@RedRoserade do you understand why some tests take > 1h? Maybe the matrix strategy has some colliding host? |
|
I don't know. I saw builds yesterday hanging with no output on the test stage, and there's currently builds going on for 4 hours as of this comment? That's not normal at all, maybe the test and docker part should be turned off for now. |
I would propose to turn off the matrix, and see if testing only with |
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
Signed-off-by: André Carvalho <afecarvalho@gmail.com>
This does a few changes, and should probably be split into multiple PRs for digestibility.
aioredistoredis-py, because the former is deprecated and moved into the main packageaioredis)isortfor sorting imports. Because of the large diff, an "ignore revs" file has been createddocker-compose.yamlfile just for Redis and RabbitMQMakefilewith common commands to format code, lint, and testStill want to implement: