Open
Conversation
Updated update-pot.sh to search also `Firmware/mmu` resources
Collaborator
|
Looking good so far, but I think it's pointless to add a review now? |
Don't translate unused AUTOTEMP messages
Add #ifdef to IR messages Sync order of messages.cpp and messages.h
Update fw-build.sh - Output used space of each translation (easier to troubleshoot) - Read config.h max size per translation - output variant .map files (easier to troubleshoot and finding missing/unused messages)
__loc_pri_end is inclusive and needs to be accounted for in get_lang_symbols(). This was incorrectly excluding the last translatable string from the map file.
_R marks a raw catalog entry as Referenced (= used) for cases where the catalog pointers are handled at a lower level.
wavexx
force-pushed
the
mk3-mmu-messages
branch
from
c0c3f76 to
209a2ed
Compare
DRracer
reviewed
Aug 10, 2022
Some are only used with two options and so longer than with 3
Remove duplicate messages
Update messages missing c= r= Don't scan to translate serial and commented out code Change MMU2 KEEPALIVE_STATE to IN_PROCESS
This message is never actually shown on the LCD (it's immediately overwritten by other content). It also include g-code in a translatable string, which is not a good idea. It's also otherwise identical to MSG_V2_CALIBRATION, which we should have used. Just remove it and save some space in the process.
Update po files after last change
3d-gussner
changed the title
DRracer
reviewed
Aug 15, 2022
| mmu_print_saved = SavedState::None; | ||
|
|
||
| KEEPALIVE_STATE(PAUSED_FOR_USER); | ||
| KEEPALIVE_STATE(IN_PROCESS); |
DRracer
reviewed
Aug 15, 2022
| UnloadingToPulley, //P4 | ||
| FeedingToFinda, // P5 | ||
| FeedingToBondtech, // P6 | ||
| FeedingToExtruder, // P6 |
Owner
There was a problem hiding this comment.
we should rename the state in the MMU FW - progress_codes.h and error_codes.h are normally copied from the MMU repo
DRracer
reviewed
Aug 15, 2022
Owner
DRracer
left a comment
DRracer
left a comment
There was a problem hiding this comment.
Well done 👍
My only complaint about this PR is the rename of "Load/Feed to Bondtech" to "Load/Feed to Extruder". I understand the intent here but the Extruder describes usually the whole assembly and not only the gears which are grabbing the filament and pushing it into the nozzle.
DRracer
approved these changes
Aug 19, 2022
DRracer
pushed a commit
that referenced
this pull request
Sep 1, 2022
DRracer
pushed a commit
that referenced
this pull request
Sep 2, 2022
DRracer
pushed a commit
that referenced
this pull request
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firmware/mmuresources#ifdefthese messages to save some bytes on MK3 / MK2.5 buildsToDo:
Autois the same in GermanAutoäöüßon LCDc=20 r=3is a hard limit as the 4th row is used for selection.Refreshand at the end ofMoreShort summary:
FS v0.3/0.4 or older/neverde-duplicated tov0.3/0.4 or older/neweras the Support already shows FSensorFinishing movements-->Finishing moves_ichanged to_n////MSG_comments_Oor_nfor serial outputpofiles#ifdefsome code#ifdef-ed IR sensor messagesMSG_and all upper-caseIN_PROCESS(Octoprint Plugins reading these)PAUSED_FOR_USERin error states or LCD interactionsfirmware_<printer type>.mapfiles to easier find messages for different variantsconfig.h