Merged
Conversation
… empty crash When Trio cancels a task (because another parallel candidate succeeded), trio.run_process only kills the direct child subprocess. But interestingness tests are shell scripts that spawn children (cp, timeout, lua, etc.) via setsid. These orphaned children continue writing to the temp directory, causing shutil.rmtree to fail with "OSError: Directory not empty". Added kill_process_group() which sends SIGKILL to the entire process group on exit from run_script_on_file. Also made temp directory cleanup robust with ignore_errors=True as defense-in-depth. Fixes #57 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Trio cancels a task (because another parallel candidate succeeded), trio.run_process only kills the direct child subprocess. But interestingness tests are shell scripts that spawn children (cp, timeout, lua, etc.) via setsid. These orphaned children continue writing to the temp directory, causing shutil.rmtree to fail with "OSError: Directory not empty".
Added kill_process_group() which sends SIGKILL to the entire process group on exit from run_script_on_file. Also made temp directory cleanup robust with ignore_errors=True as defense-in-depth.
Fixes #57