Fix for very large number of samples #677
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the fact that ALE creates outrageously large linescan models, with one pose sample per line, which makes mapprojection and bundle adjustment almost unusable, as a huge amount of time is spent simply loading the cameras.
The fix is to produce one pose sample per 10 lines. This should be more than enough, given how little the camera poses change in orbit.
There is no reason to think the current approach of one sample per line is more accurate. All of these interpolate into the true number of samples recorded in spice in either case. Then, in the usgscsm linescan model, there's additional Lagrange interpolation.
I tested this very carefully for LRO NAC, and I will be using this for more than 1000 images for a Moon map project. Projecting from the camera to the ground and back brings one to within 0.061 pixels of starting pixel.
Maybe a different fix is desired, as proposed in #655.
But I think there should be a sense of urgency for this as the problem is rather notable and the fix is rather simple.
Here are some good LRO NAC images to test with: M1285980578RE, M1104890331LE, M1104883188RE.
The ASP cam_test program can test old vs new implementation.
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: