Skip to content

Minor changes to Burchard & Rennau discrete variance decay algorithm #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanschlichting wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor changes to Burchard & Rennau discrete variance decay algorithm #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6298bd3
fixes a conditional related to TS_VAR
Jun 3, 2025
a5ed567
fixed TS_VAR conditionals in step3d_t.F and updated docs
Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ROMS/Nonlinear/set_avg.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3865,6 +3865,7 @@ SUBROUTINE set_avg_tile (ng, tile, &
& EWperiodic(ng), NSperiodic(ng), &
& AVERAGE(ng)%avgAKr)
# endif
END IF
# endif
# endif

Expand Down
17 changes: 14 additions & 3 deletions ROMS/Nonlinear/step3d_t.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,23 +1973,34 @@ SUBROUTINE step3d_t_tile (ng, tile, &
END DO
# ifdef TS_VAR
!
! Compute tracer variance.
! Compute numerical and physical destruction of tracer variance.
!
itrc=inert(1)
DO j=JstrR,JendR
DO i=IstrR,IendR
DO k=1,N(ng)
# if !defined SPLINES_VDIFF || defined TS_MPDATA
# if !defined SPLINES_VDIFF
! Multiply by oHz to convert to Tunits.
t(i,j,k,nnew,itrc)=t(i,j,k,nnew,itrc)*oHz(i,j,k)
t(i,j,k,nnew,itrc+1)=t(i,j,k,nnew,itrc+1)*oHz(i,j,k)
# endif
# else
! Multiply by oHz to convert to Tunits. Only necessary for MPDATA.
if ((Hadvection(itrc,ng)%MPDATA)) then
t(i,j,k,nnew,itrc)=t(i,j,k,nnew,itrc)*oHz(i,j,k)
t(i,j,k,nnew,itrc+1)=t(i,j,k,nnew,itrc+1)*oHz(i,j,k)
end if
# endif
! Compute numerical mixing: mnum = ( A{c^2} - (A{c})^2 ) / dt
t(i,j,k,nnew,itrc+2)=(t(i,j,k,nnew,itrc+1)- &
& t(i,j,k,nnew,itrc)*t(i,j,k,nnew,itrc))/&
& dt(ng)
END DO
DO k=1,N(ng)-1
! Compute vertical salinity gradient
cff=(t(i,j,k+1,nnew,isalt)-t(i,j,k,nnew,isalt))/ &
& (z_r(i,j,k+1)-z_r(i,j,k))
! Compute destruction of vertical salinity variance,
! mphy = 2*kappa_v*(ds/dz)^2
AKr(i,j,k)=2.0_r8*cff*cff*(Akt(i,j,k,itemp)- &
& Akt_bak(itemp,ng))
END DO
Expand Down