Open
Conversation
In the original build, much of the common logic between WTMP components was shared in the parent project. As the layout of the project has changed to separate out the components, move that common logic into conventions files which can be more easily shared between projects. This also breaks down the common shared logic into separate files based on separate concerns-- Dependency management, Java configuration, publishing settings, and version information. These files can be shared between other components with minimal or no changes.
Version catalog allows a cental location for all dependencies to be stored. In addition to this, remove any logic that was pulled out into the conventions files, and reference those instead.
Most Gradle projects include a wrapper for faster boostrapping and framework version consistency. This was a part of the parent project previously, include it as part of the Git project directly now.
Using this file, the Git library can be included in a composite build with the right boostrapping code to reference the file. This allows combining multiple separate Gradle builds into a single environment easily, which makes cross-cutting changes much simpler, and allows building libraries cohesively.
22e4a71 to
ec2e7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes restore the ability to build the Git library standalone, as well as bringing it up to more modern Gradle standards.