[CU-86b7ugbme] Fixed SQL identifier quoting #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ch-dna
commented
Jan 30, 2026
ch-dna
commented
- refactored rewriting steps into streamlined location applyQueryRewrites()
- Added quoteIdentifier helper method that escapes embedded quotes
- Added tests for specific edge case of table starting with number
added 2 commits
January 29, 2026 21:51
- Refactored getTableNameInCorrectFormat() to properly quote all parts (catalog, schema, table) - Added quoteIdentifier helper method that escapes embedded quotes - Added tests for edge cases like underscore-prefixed tables, special chars, and quote escaping
- reverted refactor of getTableNameInCorrectFormat() - refactored rewriting steps into streamlined location applyQueryRewrites() - Added quoteIdentifier helper method that escapes embedded quotes - Added tests for specific edge case
angelo-DNAStack
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.