-
Notifications
You must be signed in to change notification settings - Fork 61
Support for Darwin clang toolchain #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please squash your commits into one commit. Also, is this still a work-in-progress or is it ready for review? |
|
Hi @steven-bellock, |
|
@itsManjeet , please don't use "merge" directly. Please always use "rebased and merge" in your local, before submit the PR. |
|
From 22-Sep-2025 meeting, would be good to add support to libspdm first so that issues can be caught before syncing to |
|
@itsManjeet , could you please submit PR to https://github.com/DMTF/libspdm? |
|
I see you add Darwin for all CIs. Do you have estimation on how long they will take? |
|
Not sure about the exact numbers but CI on my fork took around 20min |
|
I feel 20 min for Darwin is too long. |
|
yes, darwin kill tasks if run with make -j nproc, so using j1, make if way slow. Nope, nothing special in darwin build, only toolchain setup in CMakeLists.txt for darwin, so yes, we can skip darwin CI |
|
Added CMake configurations to support build on darwin clang toolchain. Tested for following configurations - ARCH=aarch64 CRYPTO=openssl TOOLCHAIN=CLANG Signed-off-by: itsManjeet <itsmanjeet1998@gmail.com>
Added CMake configurations to support build on darwin clang toolchain.
Tested for following configurations