Skip to content

Conversation

@itsManjeet
Copy link

Added CMake configurations to support build on darwin clang toolchain.
Tested for following configurations

  • ARCH=aarch64 CRYPTO=openssl TOOLCHAIN=CLANG

@steven-bellock
Copy link
Contributor

Please squash your commits into one commit. Also, is this still a work-in-progress or is it ready for review?

@itsManjeet
Copy link
Author

Hi @steven-bellock,
This is still a work in progress. The GitHub CI setup is not yet complete—so far, only the FIPS build pass has been implemented.

@steven-bellock steven-bellock marked this pull request as draft August 4, 2025 16:35
@jyao1
Copy link
Member

jyao1 commented Sep 5, 2025

@itsManjeet , please don't use "merge" directly.

Please always use "rebased and merge" in your local, before submit the PR.

@itsManjeet itsManjeet changed the title [WIP] Support for Darwin clang toolchain Support for Darwin clang toolchain Sep 22, 2025
@itsManjeet itsManjeet marked this pull request as ready for review September 22, 2025 09:56
@steven-bellock
Copy link
Contributor

From 22-Sep-2025 meeting, would be good to add support to libspdm first so that issues can be caught before syncing to spdm-emu.

@jyao1
Copy link
Member

jyao1 commented Oct 13, 2025

@itsManjeet , could you please submit PR to https://github.com/DMTF/libspdm?

@itsManjeet
Copy link
Author

DMTF/libspdm#3284

@jyao1
Copy link
Member

jyao1 commented Nov 13, 2025

I see you add Darwin for all CIs.

Do you have estimation on how long they will take?

@itsManjeet
Copy link
Author

Not sure about the exact numbers but CI on my fork took around 20min

@jyao1
Copy link
Member

jyao1 commented Nov 13, 2025

I feel 20 min for Darwin is too long.
We already covered GCC and Visual Studio.
Is there any code you believe that is Darwin specific?

@itsManjeet
Copy link
Author

itsManjeet commented Nov 13, 2025

yes, darwin kill tasks if run with make -j nproc, so using j1, make if way slow.

Nope, nothing special in darwin build, only toolchain setup in CMakeLists.txt for darwin, so yes, we can skip darwin CI

@steven-bellock
Copy link
Contributor

yes, darwin kill tasks if run with make -j nproc, so using j1, make if way slow.

@itsManjeet see DMTF/libspdm#3362.

Added CMake configurations to support build on darwin clang toolchain.
Tested for following configurations
- ARCH=aarch64 CRYPTO=openssl TOOLCHAIN=CLANG

Signed-off-by: itsManjeet <itsmanjeet1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants