Skip to content

Conversation

@ancolli
Copy link

@ancolli ancolli commented May 19, 2025

Modified the member function to be compatible with changing meshes.
The implementation follows the approach used in isoAlpha.C, which has been verified to work correctly with mesh motion.

ancolli added 2 commits May 17, 2025 17:53
resizing to cope with changing meshes
Update member function in isoSurface.C to support dynamic meshes
@HenningScheufler
Copy link
Collaborator

thanks for the PR can you merge into of2406?

@ancolli ancolli changed the base branch from master to ci/of2406 June 10, 2025 19:31
@ancolli
Copy link
Author

ancolli commented Jun 10, 2025

Done!

@ancolli ancolli closed this Jun 10, 2025
@ancolli ancolli reopened this Jun 10, 2025
Copy link
Collaborator

@isoAdvector isoAdvector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

facePts seems to be unused - if so, remove. Same in isoAlpha.

By the way: Difference between isoAlpha and isoSurface needs documentation.
Current descritption in header of isoSurface.H: "Water saturation curve by Roche-Magnus"
Replace with proper description (main diff from isoAlpha: Support for LTS and dVf_ replaced by alphaPhi, if I remember correctly).

Should isoAlpha and isoSurface eventually be merged?

@ancolli
Copy link
Author

ancolli commented Jun 24, 2025

Hi, isoSurface is the only one working in my case. I did not go into the details of the differences between the two methods yet. Regarding the underlying theory, should I refer to:
Oenby J, Bredmose H, Jasak H. 2016. A computational method for sharp interface advection. R. Soc. Open Sci. 3: 160405.
http://dx.doi.org/10.1098/rsos.160405?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants