of2206 port #39
Open
of2206 port #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create openfoam.yml
wrong keyword and number of processor
FIX compile with clang
* Update openfoam.yml * bumped version in test * libglu1 missing
Collaborator
|
Thanks for the pull request could you update the CI to of2206 |
Author
|
Sure, I'll give it a go |
Author
|
There are multiple failures, you can check them up in my fork or I can submit a new merge request. Most of the errors are missing&wrong keywords in the test case setup and there are errors in duplicate entries in the RTS tables . The problem is, TwoPhaseFlow duplicates the structure in VoF in OpenFOAM - the way around this would be to wclean VoF in OpenFOAM before compiling TwoPhaseFlow. I can add the wclean into the workflow, but what do we do about the key errors? I won't have much time to deal with this in the next two weeks. |
Collaborator
|
the branch of2206 works and all test pass. the main issue was that the wrong header of zoneDistribute was used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion: best if it is merged with a new branch of2206 and checked, port is work in progress.