Skip to content

Conversation

@atsareg
Copy link
Contributor

@atsareg atsareg commented Nov 19, 2024

This PR is a follow-up of #7888 to make names for the service handlers following the standard convention. The PR propagated to integration replaces #7893. This also means that upon the update the DIRAC installations using already the Tornado TokenManager service will have to update the TokenManager service configuration by adding the HandlerPath option:

HandlerPath = DIRAC/FrameworkSystem/Service/TornadoTokenManagerHandler.py

This will be reflected in the release notes and instructions

BEGINRELEASENOTES

*Framework
CHANGE: Rename TokenManager service classes to follow standard convention for tornado and diset handlers

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Nov 19, 2024
@@ -1,6 +1,8 @@
"""TokenManager service is responsible for token management, namely storing, updating,
"""TokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""TokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating,
"""TornadoTokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating,

@fstagni fstagni merged commit 6504d15 into DIRACGrid:rel-v8r0 Nov 19, 2024
25 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 19, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11916702132

Failed:

  • integration
    cherry-pick 6504d15 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-6504d155a-integration
    git cherry-pick -x -m 1 6504d155a
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7895 Standard naming for TokenManager service classes' --author='Andrei Tsaregorodtsev <atsareg@in2p3.fr>'
    git push -u origin cherry-pick-2-6504d155a-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Standard naming for TokenManager service classes' \
         --body 'Sweep #7895 `Standard naming for TokenManager service classes` to `integration`.
    
    Adding original author @atsareg as watcher.
    
    BEGINRELEASENOTES
    
    *Framework
    CHANGE: Rename TokenManager service classes to follow standard convention for tornado and diset handlers
    
    ENDRELEASENOTES
    Closes #7897'

fstagni added a commit to fstagni/DIRAC that referenced this pull request Nov 20, 2024
[8.0] Standard naming for TokenManager service classes

(cherry picked from commit 6504d15)
fstagni pushed a commit to fstagni/DIRAC that referenced this pull request Nov 20, 2024
fstagni added a commit to fstagni/DIRAC that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants