Fix missing module imports after Math Brain refactoring#294
Draft
Copilot wants to merge 2 commits intocodex/fix-report-generation-birth-data-errorfrom
Draft
Fix missing module imports after Math Brain refactoring#294Copilot wants to merge 2 commits intocodex/fix-report-generation-birth-data-errorfrom
Copilot wants to merge 2 commits intocodex/fix-report-generation-birth-data-errorfrom
Conversation
- Add mapT2NAspects export to orchestrator and import in monolith - Add subjectToAPI export to orchestrator and import in monolith - Fix scaleDirectionalBias import in seismograph-engine (move from metric-labels to canonical-scaling) - Export enrichDailyAspects, selectPoeticAspects, weightAspect, and related constants from monolith for seismograph-engine lazy loading - Fix mock API responses in tests to include required data.person.planets structure These changes fix the calculateSeismograph function and related dependencies, resolving the test failures mentioned in the PR review. Co-authored-by: DHCross <45954119+DHCross@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Normalize Math Brain birth data payload
Fix missing module imports after Math Brain refactoring
Nov 10, 2025
Owner
|
Closing as stale (2+ months) - Math Brain imports have been refactored since. If fixes are still needed, please reopen against current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests failed with
ReferenceError: [function] is not definedafter Math Brain was refactored into separate modules. The seismograph-engine and monolith were calling functions that weren't properly exported through the module boundaries.Changes
Module orchestration:
mapT2NAspectsandsubjectToAPIfrom orchestratorenrichDailyAspects,selectPoeticAspects,weightAspect, and related constants from monolith for seismograph-engine's lazy-loading patternImport paths:
scaleDirectionalBiasimport in seismograph-engine (wasmetric-labels, should becanonical-scaling)Test fixtures:
data.person.planetsstructure to mock API responsesResult
18/19 tests passing (was 7/19). Remaining failure is unrelated provenance metadata issue in NATAL_ASPECTS mode.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.