Release: develop -> main #2948
Merged
Release: develop -> main #2948
+97
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: match FiatOutput to BankTx via endToEndId fallback LiqManagement FiatOutputs (e.g. transfers to Kraken/exchanges) have no remittanceInfo set, causing the matching in searchOutgoingBankTx() to fail even though the BankTx exists with matching endToEndId. Changes: - Add getBankTxByEndToEndId() to BankTxService - Extend getMatchingBankTx() to try endToEndId as fallback when remittanceInfo is not set or doesn't match This fixes FiatOutputs stuck in isComplete=false despite successful Yapeal transmission and existing DBIT BankTx entries. * refactor: add DBIT filter, logging and tests for endToEndId matching - Filter getBankTxByEndToEndId to only return DEBIT transactions (prevents matching incoming CRDT transactions by accident) - Add info log when matching via endToEndId for debugging - Add 3 unit tests for searchOutgoingBankTx: - Match via remittanceInfo - Match via endToEndId fallback (LiqManagement case) - Reject if BankTx created before FiatOutput.isReadyDate * feat: set BankTxType.INTERNAL for LiqManagement FiatOutputs When matching LiqManagement FiatOutputs, set the BankTx type to INTERNAL instead of leaving it as Pending. This provides clearer categorization for financial reporting and prevents the BankTx from being picked up by other assignment processes. * fix: removed log --------- Co-authored-by: David May <david.leo.may@gmail.com>
TaprootFreak
approved these changes
Jan 15, 2026
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist