Skip to content

Add SafeAccount multi-account system #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TaprootFreak merged 8 commits into from
Jan 13, 2026
Merged

Add SafeAccount multi-account system #2602

TaprootFreak merged 8 commits into from
Jan 13, 2026

Conversation

@TaprootFreak
Copy link
Collaborator

@TaprootFreak TaprootFreak commented Dec 9, 2025 •
edited
Loading

Summary

  • Implement SafeAccount entity for multi-account custody management
  • Add SafeAccountAccess entity for READ/WRITE permission management
  • Create SafeAccountService with legacy mode support (no data migration needed)
  • Add SafeAccountController with CRUD endpoints
  • Add access guards for permission-based endpoint protection
  • Extend User, CustodyBalance, and CustodyOrder entities with SafeAccount relations

Features

  • Multiple SafeAccounts per UserData
  • Shared access with READ (view, deposit) and WRITE (withdraw, swap, send) permissions
  • Legacy mode: Users without SafeAccounts see aggregated CUSTODY users as one "virtual Safe"
  • No breaking changes for existing users

Related

Test plan

  • Create a new SafeAccount via POST /safe-account
  • List SafeAccounts via GET /safe-account
  • Update SafeAccount via PUT /safe-account/:id
  • Verify legacy mode for users without SafeAccounts
  • Test access guards for READ/WRITE permissions

@TaprootFreak
Add SafeAccount multi-account system
615cbcd 
- Add SafeAccount and SafeAccountAccess entities
- Add SafeAccountService with legacy mode fallback
- Add SafeAccountController with CRUD endpoints
- Add SafeAccountReadGuard and SafeAccountWriteGuard
- Extend User, CustodyBalance, CustodyOrder with safeAccount relations
- Add database migration for new tables
@TaprootFreak TaprootFreak mentioned this pull request Dec 9, 2025
Open
4 tasks
@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

⚠️ Non-Conventional Commits (2)

The following commits don't follow conventional commit format:

  • 615cbcd Add SafeAccount multi-account system
  • 0f17aa6 Merge branch 'develop' into feature/safe-account-multi-account

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert

⚠️ Security: 0 critical, 61 high vulnerabilities

@TaprootFreak
Copy link
Collaborator Author

TaprootFreak commented Jan 13, 2026

Du hast es kaputt gemacht 💥

@TaprootFreak TaprootFreak merged commit e004e8c into develop Jan 13, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feature/safe-account-multi-account branch January 13, 2026 23:29
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidleomay davidleomay davidleomay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TaprootFreak @davidleomay