Skip to content

[DEV-3957] partner fee #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Yannick1712 wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

[DEV-3957] partner fee #2491

Yannick1712 wants to merge 14 commits into from

Conversation

@Yannick1712
Copy link
Member

@Yannick1712 Yannick1712 commented Oct 7, 2025

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

@Yannick1712
Copy link
Member Author

Yannick1712 commented Oct 7, 2025 •
edited
Loading

  • add migration
  • adapt services
  • adapt ref payout to payout partnerFees
  • new wallet col (user): owner
  • addition partnerFeeCol in buyCrypto/buyFiat ref (add it to ref calculation)

davidleomay
davidleomay reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@davidleomay davidleomay left a comment •
edited by Yannick1712
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Improve naming

davidleomay
davidleomay requested changes Nov 12, 2025
View reviewed changes
Copy link
Member

@davidleomay davidleomay left a comment •
edited by Yannick1712
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Implement partner fee payout

@Yannick1712
Copy link
Member Author

Yannick1712 commented Nov 18, 2025 •
edited
Loading

  • adapt migration
  • replace cake wallet fee + set cake wallet owner

@davidleomay
Merge branch 'develop' into feature/DEV-3957-partner-fee
7938283 
# Conflicts:
#	src/subdomains/core/sell-crypto/process/buy-fiat.entity.ts
#	src/subdomains/supporting/payment/services/fee.service.ts
#	src/subdomains/supporting/payment/services/transaction-helper.ts
@davidleomay davidleomay force-pushed the feature/DEV-3957-partner-fee branch from 9f3cc4e to 7938283 Compare January 13, 2026 10:21
@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited by atlassian bot
Loading

⚠️ Unverified Commits (11)

The following commits are not signed/verified:

  • 8d04a5e DEV-3957 partner fee (Yannick1712)
  • f194fe1 Merge branch 'develop' into feature/DEV-3957-partner-fee (Yannick1712)
  • a420c4c DEV-3957 add partnerFeeAmount (Yannick1712)
  • bd5c211 DEV-3957 find partnerFee in default (Yannick1712)
  • 0850d08 Merge branch 'develop' into feature/DEV-3957-partner-fee (Yannick1712)
  • 0920502 DEV-3957 fix dev build (Yannick1712)
  • 8a6fbe9 DEV-3957 Renaming to platform fee (Yannick1712)
  • 03039fc DEV-3957 fix build (Yannick1712)
  • ebefd9a DEV-3957 add migration (Yannick1712)
  • 45f7893 DEV-3957 partner fee payout (Yannick1712)
  • 1de9c62 DEV-3957 add partnerRef cols (Yannick1712)
How to sign commits 
# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

⚠️ Non-Conventional Commits (14)

The following commits don't follow conventional commit format:

  • 8d04a5e DEV-3957 partner fee
  • f194fe1 Merge branch 'develop' into feature/DEV-3957-partner-fee
  • a420c4c DEV-3957 add partnerFeeAmount
  • bd5c211 DEV-3957 find partnerFee in default
  • 0850d08 Merge branch 'develop' into feature/DEV-3957-partner-fee
  • 0920502 DEV-3957 fix dev build
  • 8a6fbe9 DEV-3957 Renaming to platform fee
  • 03039fc DEV-3957 fix build
  • ebefd9a DEV-3957 add migration
  • 8032502 DEV-3957 Refactoring ([DEV-3957] Refactoring #2534)
  • 45f7893 DEV-3957 partner fee payout
  • 1de9c62 DEV-3957 add partnerRef cols
  • 7938283 Merge branch 'develop' into feature/DEV-3957-partner-fee
  • 4d5028c DEV-3957 Fixed tests

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert

⚠️ Security: 0 critical, 65 high vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaprootFreak TaprootFreak Awaiting requested review from TaprootFreak TaprootFreak is a code owner

@davidleomay davidleomay Awaiting requested review from davidleomay davidleomay is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yannick1712 @davidleomay