Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This enables the use of Icechunk data stores in the Navigator as the first step in replacing our current data indexing solution. Most of these changes are related to updating the configurations and tests. Only minor changes were needed to actually enable the use of Icechunk.
This approach only supports S3 and local file storage configurations. In production MinIo will be used to enable data access while the local option is only used for testing however users could configure their own Navigator deployments to use either.
Why did you take this approach?
Since Icechunk interfaces so well with xarray we only needed to add functions to access the repositories. Everything else in the dataflow should be business as usual.
Anything in particular that should be highlighted?
All code related to our current data indexing solution has been left intact but will likely be removed once we fully migrate to this approach.
Checks
black ..