Upgrade Stylelint to v17

[scruti]

Trello card URL

Fixing issues in Dependabot updates by grouping them into a single compatible update.

• Bump stylelint from 15.11.0 to 17.5.0 #8684
• Bump stylelint-config-sass-guidelines from 10.0.0 to 13.0.0 #8649

Fixed new style violations raised by the version upgrades.

Changes in this PR:

Upgrade Stylelint and Stylelint config SASS guidelines packages to their latest compatible versions (Stylelint config SASS guidelines states that is compatible with Stylelint v17.1).

Checklists:

Data & Schema Changes

If this PR modifies data structures or validations, check the following:

• Adds/removes model validations
• Adds/removes database fields
• Modifies Vacancy enumerables (phases, working patterns, job roles, key stages, etc.)

If any of the above options has changed then the author must check/resolve all of the following...

Integration Impact

Does this change affect any of these integrations?

• DfE Analytics platform
• Legacy imports mappings
• DWP Find a Job export mappings
• Publisher ATS API (may require mapping updates or API versioning)

User Experience & Data Integrity

Could this change impact:

• Existing subscription alerts (will legacy subscription search filters break?)
• Legacy vacancy copying (will copied vacancies fail new validations?)
• In-progress drafts for Vacancies or Job Applications

[Copilot]

Pull request overview

Upgrades Stylelint and the Sass guidelines config to the latest compatible v17 toolchain and applies formatting tweaks to SCSS files to satisfy new/updated lint rules.

Changes:

• Upgrade stylelint to v17 and stylelint-config-sass-guidelines to v13 (plus transitive lockfile updates).
• Update Stylelint SCSS rule config to the newer scss/load-no-partial-leading-underscore rule name.
• Apply SCSS formatting/modern-Sass adjustments (selector wrapping, indentation, sass:color module usage) to clear new lint violations.

Reviewed changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
yarn.lock	Locks Stylelint v17-era dependency graph and transitive upgrades needed for compatibility.
package.json	Bumps Stylelint + Sass guidelines config versions used by sass:lint.
app/assets/stylesheets/layouts/vacancies/index.scss	Reformats multi-selector rule to satisfy updated linting expectations.
app/assets/stylesheets/layouts/shared/_search-results.scss	Reformats multi-selector rules for lint compliance.
app/assets/stylesheets/layouts/hero.scss	Fixes indentation/formatting to match style rules.
app/assets/stylesheets/components/sidebar.scss	Simplifies equivalent padding shorthand / formatting for lint compliance.
app/assets/stylesheets/components/filters.scss	Corrects indentation and block structure for lint compliance.
app/assets/stylesheets/components/detail.scss	Simplifies equivalent padding shorthand / formatting for lint compliance.
app/assets/stylesheets/components/_status_tag.scss	Minor formatting fix (closing brace alignment).
app/assets/stylesheets/base/_mixins.scss	Uses sass:color module and color.mix() (modern Sass) to satisfy linting/deprecation expectations.
app/assets/stylesheets/base/_guide_card.scss	Fixes spacing and selector wrapping for lint compliance.
app/assets/stylesheets/base/_form.scss	Adds missing whitespace before { for lint compliance.
app/assets/stylesheets/application.scss	Normalizes quoting to satisfy stylelint rules.
app/assets/stylesheets/actiontext.scss	Splits long selector list across lines for lint compliance.
.stylelintrc.json	Updates deprecated SCSS rule name and removes trailing whitespace.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.