Open
Conversation
starswan
force-pushed
the
profiles-about-you
branch
from
486cf42 to
83ee291
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-8695.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
profiles-about-you
branch
from
83ee291 to
fd90bdd
Compare
starswan
force-pushed
the
profiles-about-you
branch
from
fd90bdd to
ed3eaf8
Compare
Collaborator
KyleMacPherson
left a comment
KyleMacPherson
left a comment
There was a problem hiding this comment.
Looks good so far but I think we still need to handle the existing about_you field, i.e migrate the data to about_you_richtext, handle the views pre migration and remove the about_you field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/Ycm4eUcS/2724-profile-about-you-journey
Changes in this PR:
Abouit you section renamed personal statement and made into rich text
Screenshots of UI changes:
Before
After
Checklists:
Data & Schema Changes
If this PR modifies data structures or validations, check the following:
If any of the above options has changed then the author must check/resolve all of the following...
Integration Impact
Does this change affect any of these integrations?
User Experience & Data Integrity
Could this change impact: