Open
Conversation
c10495d to
8a4c6b7
Compare
8a4c6b7 to
623b0b4
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-8675.test.teacherservices.cloud on AKS |
623b0b4 to
3b7786b
Compare
scruti
reviewed
Apr 14, 2026
| ProfessionalBodyMembership.transaction do | ||
| pbm_batch.each(&:destroy!) | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
Proposal: Couldn't we leave the schema migration for a second PR?
- This PR:
- Interface & Flow changes.
- Jobseekers can no longer add or see listed Professional Body Memberships.
- Rake task with above code, removing any existing Professional Body Membership belonging to Jobseeker Profiles.
- Second PR:
- Schema migration
- Removal of model association
- Analytics, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/WXACw5a1/2674-profile-professional-body-memberships-journey
Changes in this PR:
Remove professional memberships from profiles
Screenshots of UI changes:
Before
After