Conversation
starswan
changed the title
|
Review app deployed to https://teaching-vacancies-review-pr-8666.test.teacherservices.cloud on AKS |
KyleMacPherson
left a comment
KyleMacPherson
left a comment
There was a problem hiding this comment.
The ticket seems to suggest that we just want to change some hint text, but this looks like it's adding in an extra, previously deleted field. I may well be missing context here but based on the ticket I don't think this looks quite right
| validates_format_of :teacher_reference_number, with: /\A\d{7}\z/, allow_blank: false, if: -> { has_teacher_reference_number } | ||
| validates :is_statutory_induction_complete, inclusion: { in: [true, false] }, if: -> { qualified_teacher_status == "yes" } | ||
|
|
||
| validates :has_teacher_reference_number, inclusion: { in: [true, false] } |
There was a problem hiding this comment.
It looks like we are re-introducing has_teacher_reference_number which we got rid of a few months ago. I don't see this mentioned on the ticket, is this part of this work?
| = f.govuk_text_area :qualified_teacher_status_details | ||
| = f.govuk_radio_button :qualified_teacher_status, "on_track" | ||
|
|
||
| = f.govuk_radio_buttons_fieldset :has_teacher_reference_number, legend: { tag: "h2" }, |
There was a problem hiding this comment.
It looks like we are re-introducing has_teacher_reference_number which we got rid of a few months ago. I don't see this mentioned on the ticket, is this part of this work?
There was a problem hiding this comment.
I was following the designs (I think) - we're changing the layout of the page, so I assumed that we were bringing back the radio button?
There was a problem hiding this comment.
Good catch @KyleMacPherson. I suspect the design on the Lucid is outdated from the start, since the "Current Profiles" initial screenshots contain the outdated design with the removed radio button, while in reality now looks like this:
@starswan you can double-check with Alice, but given how much of a pain was the radio with the has_teacher_reference_number field, and how relieved we were once removed, I wouldn't expect going back to the previous state of that question. So I'm pretty sure it is an outdated design.
There was a problem hiding this comment.
I asked in the TV Product channel and it looks like the screenshots used for the Lucid board are in fact just out of date so we don't want to add back in that question. Annoying, I know!
3 participants
Trello card URL
https://trello.com/c/HnQ2ivZL/2672-profile-qualifications-journey
Edit: Think it is this one: https://trello.com/c/xHVsNEI4/2671-profile-professional-status-qts-journey (KM)
Changes in this PR:
QTS Profiles page
Screenshots of UI changes:
Before
After