Open
Conversation
starswan
changed the title
starswan
force-pushed
the
profile-job-preferences
branch
from
fab71ef to
f291302
Compare
starswan
force-pushed
the
profile-job-preferences
branch
from
f291302 to
2752328
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-8665.test.teacherservices.cloud on AKS |
KyleMacPherson
approved these changes
Apr 8, 2026
Collaborator
KyleMacPherson
left a comment
KyleMacPherson
left a comment
There was a problem hiding this comment.
Approved with a couple of non blocking comments!
|
|
||
| validates :roles, presence: true | ||
| validate :validate_roles | ||
| validates :roles, presence: true, length: { maximum: 4 } |
Collaborator
There was a problem hiding this comment.
[Minor] Do we want to add a custom error message for >4 roles?
| class KeyStagesForm < ProfilesForm | ||
| attribute :key_stages, array: true, default: [] | ||
| validates :key_stages, presence: true | ||
| validates :key_stages, presence: true, length: { maximum: 3 } |
Collaborator
There was a problem hiding this comment.
[Minor] Do we want to add a custom error message for >3 key stages? Is it worth adding a test for this validation too?
Contributor
Author
There was a problem hiding this comment.
they were there but untested. Thanks for the nudge
starswan
force-pushed
the
profile-job-preferences
branch
from
2752328 to
14f225d
Compare
starswan
force-pushed
the
profile-job-preferences
branch
from
14f225d to
28e30e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/J24ZKPxT/2725-profile-job-preferences-journey
Changes in this PR:
Updates to job preferences for profiles rework
Screenshots of UI changes:
Before
After