Open
Conversation
2cde2e3 to
e2f3e8c
Compare
e2f3e8c to
f91edad
Compare
a49f280 to
b31837f
Compare
089ebd0 to
7f1883e
Compare
72b160c to
dbdf31b
Compare
dbdf31b to
718a943
Compare
718a943 to
fc8b802
Compare
fc8b802 to
bf1b808
Compare
bf1b808 to
d8f13e5
Compare
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
_Numfields were not mapped correctly, causing them all to be zero_Previous2fields were not mapped correctly, due to source data file for 2021-22 destinations only havingschool_laestabcolumn notschool_urn, so filtering by URN did not work. This was fixed by modifying SQL generation to allow joining on LAESTAB as well as URNLAESTABcolumn tov_establishmentandEstablishmentmodelIKs4DestinationsRepositoryfromIKs4PerformanceRepositoryas these are distinct data sets and should be kept separate