Skip to content

Bugfix: Fix Destinations data issues#124

Open
stusherwin wants to merge 4 commits intomainfrom
destinations-fix
Open

Bugfix: Fix Destinations data issues#124
stusherwin wants to merge 4 commits intomainfrom
destinations-fix

Conversation

@stusherwin
Copy link
Copy Markdown
Collaborator

@stusherwin stusherwin commented Mar 31, 2026

This PR does the following:

  • Fixes issue where Destinations data was not being populated in the repository due to incorrect column names
  • Fixes issue where _Num fields were not mapped correctly, causing them all to be zero
  • Fixes issue where _Previous2 fields were not mapped correctly, due to source data file for 2021-22 destinations only having school_laestab column not school_urn, so filtering by URN did not work. This was fixed by modifying SQL generation to allow joining on LAESTAB as well as URN
  • Adds LAESTAB column to v_establishment and Establishment model
  • Extracts out IKs4DestinationsRepository from IKs4PerformanceRepository as these are distinct data sets and should be kept separate
  • Fixes both repositories to only send a single database request per repository method

@stusherwin stusherwin changed the title Destinations fix Bugfix: Fix Destinations data issues Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 75.18%

Minimum allowed coverage is 0%, this run produced 75.18%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant