[389, 397, 398, 399] Add api client flow#400
Merged
Conversation
Deployments
|
defong
reviewed
Apr 8, 2026
Collaborator
defong
left a comment
defong
left a comment
There was a problem hiding this comment.
Probably would of been candidate for CITEXT
https://www.postgresql.org/docs/current/citext.html
Then we don't have to bother with lower casing
A few other minor things to wrap up
tomtrentham
reviewed
Apr 8, 2026
Contributor
tomtrentham
left a comment
tomtrentham
left a comment
There was a problem hiding this comment.
I think this error message looks a bit wonky:
Co-authored-by: De Fong <470137+defong@users.noreply.github.com>
tomtrentham
requested changes
Apr 8, 2026
Contributor
tomtrentham
left a comment
tomtrentham
left a comment
There was a problem hiding this comment.
Can we get clarity on the client/token modelling please?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Co-authored-by: Tom Trentham <1910056+tomtrentham@users.noreply.github.com> Co-authored-by: De Fong <470137+defong@users.noreply.github.com>
tomtrentham
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
https://trello.com/c/7bmabknE/389-add-api-client-flow
Changes proposed in this pull request
Add flow for adding api clients
Guidance to review