Skip to content

[9424] Onboarding RoTP api (Pt. 1)#6068

Open
d-a-v-e wants to merge 16 commits intomainfrom
9424-onboarding-rotp-api-part-1
Open

[9424] Onboarding RoTP api (Pt. 1)#6068
d-a-v-e wants to merge 16 commits intomainfrom
9424-onboarding-rotp-api-part-1

Conversation

@d-a-v-e
Copy link
Copy Markdown
Contributor

@d-a-v-e d-a-v-e commented Apr 2, 2026

Context

Trello ticket

Register trainee teachers is the early adopter of the RoTP API. We want to incrementally integrate with RoTP in the Register service.

This is the first step to check Register data with RoTP data.

Changes proposed in this pull request

  • adds a simple consumer for the RoTP API
  • checker class for comparing Register/RoTP accredited providers and training partners (school-type TPs skipped as no shared identifier in RoTP)
  • job for running the check and formatting a message for teams

Guidance to review

  • @d-a-v-e will do a dry run: local against prod RoTP

successfully ran - messages can be seen in the REC Register Support channel

  • code review can be done alongside

Previews

Screenshot 2026-04-08 at 13 40 58

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to TRS as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@d-a-v-e d-a-v-e changed the title [9424] Onboarding RoTP api (pt 1) [9424] Onboarding RoTP api (Pt. 1) Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.55%. Comparing base (b72fb92) to head (851e082).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6068      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +0.01%     
==========================================
  Files         843      847       +4     
  Lines       18778    18892     +114     
==========================================
+ Hits        18129    18242     +113     
- Misses        649      650       +1     
Flag Coverage Δ
unittests 96.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@tomtrentham tomtrentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've got most of what we want. The main thing I think we need is to be able to match on schools as well, so we'll need an RoTP change to do that properly.

Comment thread app/jobs/rotp/provider_checker_job.rb Outdated
Comment thread config/settings.yml Outdated
Comment thread app/services/rotp/provider_checker.rb Outdated
Comment thread app/jobs/rotp/check_providers_job.rb Outdated
Comment thread app/services/rotp/provider_checker.rb
Comment thread app/jobs/rotp/check_providers_job.rb Outdated
Comment thread config/settings/development.yml Outdated
@d-a-v-e d-a-v-e requested review from defong and tomtrentham April 10, 2026 14:49
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@tomtrentham tomtrentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the test message worked.

Copy link
Copy Markdown
Contributor

@defong defong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants