Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6068 +/- ##
==========================================
+ Coverage 96.54% 96.55% +0.01%
==========================================
Files 843 847 +4
Lines 18778 18892 +114
==========================================
+ Hits 18129 18242 +113
- Misses 649 650 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomtrentham
reviewed
Apr 8, 2026
Contributor
tomtrentham
left a comment
There was a problem hiding this comment.
I think we've got most of what we want. The main thing I think we need is to be able to match on schools as well, so we'll need an RoTP change to do that properly.
defong
reviewed
Apr 9, 2026
tomtrentham
reviewed
Apr 9, 2026
|
tomtrentham
approved these changes
Apr 15, 2026
Contributor
tomtrentham
left a comment
There was a problem hiding this comment.
Looks good and the test message worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Context
Trello ticket
Register trainee teachers is the early adopter of the RoTP API. We want to incrementally integrate with RoTP in the Register service.
This is the first step to check Register data with RoTP data.
Changes proposed in this pull request
accredited providersandtraining partners(school-type TPs skipped as no shared identifier in RoTP)Guidance to review
Previews
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml