Conversation
Reyko
force-pushed
the
9494-add-restriction-to-api-for-updating-trainees-who-hold-qts-eyts
branch
from
878715e to
c887e26
Compare
Contributor
|
Review app for PR pr-6063 was deleted |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6063 +/- ##
=======================================
Coverage 96.53% 96.54%
=======================================
Files 842 843 +1
Lines 18757 18774 +17
=======================================
+ Hits 18108 18125 +17
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reyko
force-pushed
the
9494-add-restriction-to-api-for-updating-trainees-who-hold-qts-eyts
branch
from
c887e26 to
52610f9
Compare
tomtrentham
reviewed
Apr 2, 2026
Contributor
tomtrentham
left a comment
tomtrentham
left a comment
There was a problem hiding this comment.
Nice implementation and tidy-up too. A couple of comments mostly around the docs 📜
Contributor
Reyko
changed the title
Co-authored-by: Tom Trentham <1910056+tomtrentham@users.noreply.github.com>
Reyko
force-pushed
the
9494-add-restriction-to-api-for-updating-trainees-who-hold-qts-eyts
branch
from
2b1d890 to
f96c390
Compare
tomtrentham
approved these changes
Apr 7, 2026
Contributor
tomtrentham
left a comment
tomtrentham
left a comment
There was a problem hiding this comment.
One minor markdown tweak, otherwise all good.
Contributor
Co-authored-by: Tom Trentham <1910056+tomtrentham@users.noreply.github.com>
|
Reyko
deleted the
9494-add-restriction-to-api-for-updating-trainees-who-hold-qts-eyts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
9494-add-restriction-to-api-for-updating-trainees-who-hold-qts-eyts
Changes proposed in this pull request
Prevent updates if the trainee is in
recommended_for_award,withdrawnorawardedstate, via:/trainees/{trainee_id}/trainees/{trainee_id}/placements/{placement_id}/trainees/{trainee_id}/degrees/{degree_id}/trainees/{trainee_id}/placements/{placement_id}/trainees/{trainee_id}/degrees/{degree_id}/trainees/{trainee_id}/placements/trainees/{trainee_id}/degreesGuidance to review
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml