Skip to content

[9469] Make error messages full width#6050

Merged
Reyko merged 7 commits intomainfrom
9469-make-error-messages-full-width
Apr 7, 2026
Merged

[9469] Make error messages full width#6050
Reyko merged 7 commits intomainfrom
9469-make-error-messages-full-width

Conversation

@Reyko
Copy link
Copy Markdown
Contributor

@Reyko Reyko commented Mar 26, 2026

Context

9469-make-error-messages-full-width

Changes proposed in this pull request

  • Make error messages occupy the full width of the page in forms

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to TRS as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@Reyko Reyko force-pushed the 9469-make-error-messages-full-width branch from d6f94bd to f7d5b7b Compare March 26, 2026 10:13
@Reyko Reyko marked this pull request as ready for review March 26, 2026 10:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Review app for PR pr-6050 was deleted

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (0d1e6e7) to head (b942ba0).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6050   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         842      842           
  Lines       18757    18757           
=======================================
  Hits        18107    18107           
  Misses        650      650           
Flag Coverage Δ
unittests 96.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@tomtrentham tomtrentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've found another one which needs changing. Perhaps the only one not using govuk_error_summary:

app/views/trainees/itt_dates/edit.html.erb

Image

Copy link
Copy Markdown
Contributor

@tomtrentham tomtrentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Reyko Reyko force-pushed the 9469-make-error-messages-full-width branch from b859c0b to b942ba0 Compare March 31, 2026 08:24
@sonarqubecloud
Copy link
Copy Markdown

@Reyko Reyko merged commit 0b86f95 into main Apr 7, 2026
39 checks passed
@Reyko Reyko deleted the 9469-make-error-messages-full-width branch April 7, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants