Merged
Conversation
added 2 commits
February 13, 2026 18:01
hbrincon
commented
Feb 14, 2026
|
|
||
| for cat_name, file_name in zip(cat_names, file_names): | ||
| self._catalogs[cat_name] = VoidFinderCatalog(file_name) | ||
| self._catalogs[cat_name] = VoidFinderCatalog(file_name, edge_buffer=edge_buffer) |
Contributor
Author
There was a problem hiding this comment.
Here is the bug fix for VoidFinder voids
hbrincon
commented
Feb 14, 2026
| self._catalogs[cat_name] = V2Catalog(file_name) | ||
|
|
||
|
|
||
| self._catalogs[cat_name] = V2Catalog(file_name, edge_buffer=edge_buffer) |
Contributor
Author
There was a problem hiding this comment.
Here is the bug fix for V2 voids
sybenzvi
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edge_buffer user input for the VoidFinderCatalogStacked and V2CatalogStacked classes were being mistakenly overwritten with a default value of 30 Mpc/h for each VoidFinderCatalog and V2Catalog class contained within them. This bug has been fixed so that the user input is passed between classes.
Also includes a few user-convenience features and speedups for the void_catalog classes