Add helper function and filter for addpath feature (and small bug fix)#40
Closed
cmoeller-dx wants to merge 13 commits intoDE-CIX:masterfrom
Closed
Add helper function and filter for addpath feature (and small bug fix)#40cmoeller-dx wants to merge 13 commits intoDE-CIX:masterfrom
cmoeller-dx wants to merge 13 commits intoDE-CIX:masterfrom
Conversation
cmoeller-dx
changed the title
Ipv6 (multiprotocol support)
Vlan support merge with master. Changes were mostly unrelated to previous merge (ipv6 support).
Author
|
merged with private master. changes can be found in PR #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a helper function for the addpath capabilty. In my opinion it is now more maintainable.
I also found a small bug in the Application/Handler.py file.
There was a wrong filter applied, nameley MACSourceFilter() instead of MACDestinationFilter()
This resulted in applying the MACSourceFilter twice and the MACDestinationFilter not even once.
Edit:
Add PathIdentifierFilter.
for example:
--filter-pathid 1will print update messages where the pathid is equal 1